Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CUS-1729 GitHub actions for publishing #6

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix: CUS-1729 GitHub actions for publishing #6

merged 2 commits into from
Feb 26, 2024

Conversation

emmaLP
Copy link
Contributor

@emmaLP emmaLP commented Feb 26, 2024 •
edited
Loading

JIRA ticket link/s

Summary of changes

  1. Introducing an app that has permission to write to this repo and the app have been set to be allowed to push a commit to main since it's changing the version in the package.json.
  2. Trialing the ability to sign the commits in github actions
  3. Always run build and test on every commit

Additional Info

@emmaLP emmaLP requested review from a team as code owners February 26, 2024 15:43
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f8e20b31 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8e20b3) Report Missing Report Missing Report Missing
Head commit (ec60656) 56 56 100.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@emmaLP
Copy link
Contributor Author

emmaLP commented Feb 26, 2024

Used Merge without waiting for requirements to be met (bypass branch protections) option for this PR as the changes can only be tested in the main branch

@emmaLP emmaLP merged commit ef442b7 into main Feb 26, 2024
3 of 4 checks passed
@emmaLP emmaLP deleted the fix/CUS-1798_github_actions_for_publishing branch February 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanfinners jordanfinners Awaiting requested review from jordanfinners jordanfinners is a code owner automatically assigned from gymshark/platform

@lushc lushc Awaiting requested review from lushc lushc is a code owner automatically assigned from gymshark/customer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmaLP